[Mesa-dev] [PATCH 43/59] i965/fs: fix dst width calculation in CSE

[Samuel Iglesias Gonsálvez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 02/05/16 11:01, Pohjolainen, Topi wrote:
> On Fri, Apr 29, 2016 at 01:29:40PM +0200, Samuel Iglesias Gons?lvez
> wrote:
>> From: Connor Abbott <connor.w.abbott at intel.com>
>> 
>> --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- 1 file
>> changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp
>> b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp index 15af2c1..047e4ef
>> 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp +++
>> b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp @@ -187,7 +187,7 @@
>> static void create_copy_instr(const fs_builder &bld, fs_inst
>> *inst, fs_reg src, bool negate) { int written =
>> inst->regs_written; -   int dst_width = inst->exec_size / 8; +
>> int dst_width =
>> DIV_ROUND_UP(inst->dst.component_size(inst->exec_size),
>> REG_SIZE);
> 
> Perhaps wrap the overflowing right hand size on its own line?
> 

OK, I will do it.

Thanks!

Sam

>> fs_inst *copy;
>> 
>> if (written > dst_width) { -- 2.5.0
>> 
>> _______________________________________________ mesa-dev mailing
>> list mesa-dev at lists.freedesktop.org 
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXKFZBAAoJEH/0ujLxfcNDtgAP/Ax7Pk3nwCc33Zi3Ywa/AxEV
PyxjReu4ICdSGlh/49NoAAQtJokrHOlYO8qHCwUOgU7ZszHIc0norakLpD/5HBT8
SyKpjAT6b77/tmLz6StX4AXX8+rQkUiuKY5UV80kgNsiW5GJ+kLtob5FzJ444Q6G
SKLfTFolRIjHrSqDT2JfKLKfduSGvX7y9VnfAXR8ntmt9Wydl2QdEjorfDTuInUJ
0FKYwHU6aWpwicEoAwPR1RHoFi8kXmqR9cz/199a/i0KQ3oxgbloDozafJdBBPpa
2rbKQacl74WemHA8GfQV3gsX75TktFbS080q9+fjgLT41Lkaj29ktDlM2IU3S2tT
8ozvzyV5Kgq0LklnOZ8zRmfDN3AD+Z4acGdl0pUScoICTf4NoPS5PUjc8fzLeCxo
45SUm9mURIYznOlJwSw53KqK0Tw8zTEgTqZtJC5xkopJArVkmdtwhNwRnHaI7wgR
JQo+Qr9nFH2ZZC8IbaYs40vnSXxcLPc2+UVF24UMF2XDYOx9jA5bAVi+rdg84fDC
vWecVQ4C2M98tY5TKL+VZQTTRwIIkMl7LrTzVdh5pTrQMo8igwozMCfZvUudfYY1
rauz2EdUdrNwswUD28P+ZHYrMzTmJLlk/wlLFu+880GSLSC++nbCCRsHq76arNTy
AU478s4tZ2ZBBeRSvPLl
=2S7a
-----END PGP SIGNATURE-----