[Mesa-dev] [PATCH 58/59] i965/fs: take into account doubles when calculating read_size for MOV_INDIRECT

[Samuel Iglesias Gonsálvez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 02/05/16 14:33, Pohjolainen, Topi wrote:
> On Fri, Apr 29, 2016 at 01:29:55PM +0200, Samuel Iglesias Gons?lvez
> wrote:
>> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com> 
>> --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4 ++-- 1 file
>> changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
>> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 87e098a..4cd219a
>> 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++
>> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp @@ -2924,9 +2924,9 @@
>> fs_visitor::nir_emit_intrinsic(const fs_builder &bld,
>> nir_intrinsic_instr *instr * component from running past, we
>> subtract off the size of all but * one component of the vector. 
>> */ -         assert(instr->const_index[1] >=
>> instr->num_components * 4); +
>> assert(instr->const_index[1] >= instr->num_components * (int)
>> type_sz(dest.type));
> 
> Overflowing line, perhaps instead:
> 
> assert(instr->const_index[1] >= instr->num_components * (int)
> type_sz(dest.type));
> 

OK, I'll do it.

Thanks,

Sam

>> unsigned read_size = instr->const_index[1] - -
>> (instr->num_components - 1) * 4; +
>> (instr->num_components - 1) * type_sz(dest.type);
>> 
>> for (unsigned j = 0; j < instr->num_components; j++) { 
>> bld.emit(SHADER_OPCODE_MOV_INDIRECT, -- 2.5.0
>> 
>> _______________________________________________ mesa-dev mailing
>> list mesa-dev at lists.freedesktop.org 
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXKFbDAAoJEH/0ujLxfcNDaMcP/2rY6e2ECmLAVpwcdKdY+LH5
iaPvC/QfxvQCpyAU6jIw60r5VIB+XC8ILzascalnRhg7hfXLOkJRLLTRCrth0kja
/zAHRFoMkiVvEIHvpa80uKrLJmeFCZ3iQmsDTmkVKNl5fYi1B55TQkM3L7iy8fWB
MeKR0slRMXRHwYWjdKCqXxq0YN2OeY9VQ4qGBahBKEjQST1gE0r8wiYRfV6Rjw/a
Td5ASmivEWNCao/vQbKnZa8asy8pga104AZ7j+2WMxGU7ZzohW4R8EvQUxvT0joo
er79s7x95MuJV668Ha+dut4OYG4oGPXZ8u+qYFs79rwlaWMPAAr/KszQg0Y4PeG8
dennCyJ8Yzpa2VoDqBnRXF0yipdjKY4u9bv7n9FUV+d5ywusOlWfLleFnlK1DXvf
rXdrMP7Iq1RMbbVXmmbedYyRcSmrCV3Irrw5ogCFgxAZm62G3CDO89dof8zZgaCa
D/5WOdTVL41VmatmXdQEOufw9duiV9LHu/rE4nD+FeQaTy5YKJ1nsPM3Y93QqY5E
A9xTLdjMOFAVggo7bPc8mFuXjM3xas+hT81/6owXM7ZXNG44A8tj8OXSNfnaO2Nj
iuQkeVmo3moy6UM0gT5HiMzj/ATSeq1yNFCkKeryb1JcmNGz964gBBh0UK7KLr9k
x4q0e89au3HOp+23JN8p
=Khm/
-----END PGP SIGNATURE-----