[Mesa-dev] [PATCH RESEND] Revert "i965: Always use Y-tiled buffers on SKL+"

Ben Widawsky ben at bwidawsk.net
Tue May 3 20:25:58 UTC 2016


On Tue, May 03, 2016 at 02:38:39PM +0100, Daniel Stone wrote:
> This commit broke Weston/KMS, and presumably also xf86-video-modesetting.
> 
> In order to use Y-tiled buffers, the kernel requires the tiling mode to
> be explicitly named through the I915_FORMAT_MOD_Y_TILED AddFB2 modifier;
> it disallows any attempt to infer the buffer's tiling mode.
> 
> As the GBM API does not have a way to extract modifiers for a buffer,
> this commit broke all users of GBM on SKL+. Revert it for now, until we
> get a way to extract modifier information from GBM, and also let GBM
> users inform the implementation that it intends to use the modifiers.
> 
> This reverts commit 6a0d036483caf87d43ebe2edd1905873446c9589.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> Cc: Ben Widawsky <ben at bwidawsk.net>
> Cc: Topi Pohjolainen <topi.pohjolainen at intel.com>
> Cc: Kenneth Graunke <kenneth at whitecape.org>

I'm going to take a whack at fixing this in weston/GBM...
Acked-by: Ben Widawsky <ben at bwidawsk.net>


More information about the mesa-dev mailing list