[Mesa-dev] [PATCH 41/59] i965/fs: fix is_copy_payload() for doubles

Francisco Jerez currojerez at riseup.net
Tue May 3 23:09:34 UTC 2016


Samuel Iglesias Gonsálvez <siglesias at igalia.com> writes:

> From: Connor Abbott <connor.w.abbott at intel.com>
>
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 729c7a0..45afd1a 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -372,9 +372,9 @@ fs_inst::is_copy_payload(const brw::simple_allocator &grf_alloc) const
>           return false;
>  
>        if (i < this->header_size) {
> -         reg.reg_offset += 1;
> +         reg.reg_offset += DIV_ROUND_UP(type_sz(reg.type), 4);

This seems wrong, LOAD_PAYLOAD treats each header source as a 32B block
regardless of the datatype, please drop the hunk above.

>        } else {
> -         reg.reg_offset += this->exec_size / 8;
> +         reg = horiz_offset(reg, this->exec_size);
>        }
>     }
>  
> -- 
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160503/c81f7335/attachment.sig>


More information about the mesa-dev mailing list