[Mesa-dev] [PATCH 08/11] glapi: Harden GLX request size processing

Adam Jackson ajax at redhat.com
Wed May 4 15:43:36 UTC 2016


On Mon, 2016-03-28 at 11:10 -0700, Ian Romanick wrote:

> > @@ -428,7 +428,7 @@ class PrintGlxReqSize_h(PrintGlxReqSize_common):
>       def printBody(self, api):
> >          for func in api.functionIterateGlx():
> >              if not func.ignore and func.has_variable_size_request():
> > -                print 'extern PURE _X_HIDDEN int __glX%sReqSize(const GLbyte *pc, Bool swap);' % (func.name)
> > +                print 'extern PURE _X_HIDDEN int __glX%sReqSize(const GLbyte *pc, Bool swap, int reqlen);' % (func.name)
> 
> I don't see where reqlen is used.  Did I miss something?

You didn't. It's only used (or needed) in __glXDrawArraysReqSize, which
isn't generated. But since the prototype needs to match...

 -ajax


More information about the mesa-dev mailing list