[Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

[Francisco Jerez]

Samuel Iglesias Gonsálvez <siglesias at igalia.com> writes:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
>
>
> On 03/05/16 20:59, Kenneth Graunke wrote:
>> Other than patches 37, 56, and ones you agreed to drop, the series
>> is: Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>> 
>> I think you can go ahead and land all except those, and we can
>> land new solutions for those problems afterwards.
>> 
>> We still need to fix the horiz_offset problem, and I think Curro's 
>> subscript() helper is a great way to do that.  I would be fine
>> with fixing that after this series lands - it would probably mean
>> less rebasing :)
>> 
>
> We prepared a patch series without patches 11, 22 (both were dropped),
> 37, 40 (it has a NACK from Curro) and 56. Our idea was to push the
> patch series once we check there is no piglit regressions.
>
> We got 0 piglit regressions on ILK, SNB, IVB, HSW and BDW, the latter
> with the extension enabled with the environment variable.
>
> Sadly, on SKL we had regressions (including GPU hangs) only if we
> *enable* the arb_gpu_shader_fp64 extension. Those regressions are
> fixed by patch 40 but we need still to investigate why they are happening.
>
That sounds like PATCH 40 was most likely working around regs_read()
being interpreted with incorrect units in some other place.  The use of
regs_read() in PATCH 36 is obviously wrong which might explain the
problem.  Something along the lines of 'inst->components_read(i) *
type_sz(inst->src[i]) / 4' would do what you want -- With that changed
PATCH 36 is:

 Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> For that reason, we have not pushed anything yet. Tomorrow we will
> investigate why we have those regressions only on SKL and which tests
> are affected.
>
No worries, you still have a couple of weeks until the merge deadline, I
don't see the need to rush in any changes that still have outstanding
comments.

> JFTR, if we disable the extension on SKL (i.e. we don't set the
> environment variable), we have 0 piglit regressions on that generation.
>
> Thanks,
>
> Sam
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJXKgPaAAoJEH/0ujLxfcNDtHgP/0JBd96UX2026Y0zBydrE1Ta
> U7FV5e0SJXY5JnxWqdV4ZhtdiqQ0EDLj2G0NlFq0u29c+lQX//x9KHMANxbt2tdc
> jStRm4NMNXds4rxFYaiRs+3p4XLquV4aZ33Px+0CT6m6Hjsm6sNJZViarB41SjAq
> HVRuKAxBbVTjqqPXBKAoXXxp34OUym5uZydXFjavCs1lU70DVwZq9t/vzIAGUunT
> NCbehScgtdVupTDEzORZ7QRXvGyqQoJa+HBeuEK6HvvhonfezwrB1hawIRGP34V/
> /k+UvL/DA3GEenpCqHfOIwnxVRYN6iXYNlHSNK+LolsjR/CUxccBs67tcQiGAPBA
> g8V02KHbuIN2JyXLSwzJ0ovX5aA+vr5Fuc8e+0PZ7raa7GxIsDg3LbUNnyT8dT83
> fQAM6IMFYhZUOKKF8ynqw5tvRAaUhWJwageYqRkdHROSs8toero7RDAabEdBKWhG
> scGkKEu3S7vsGLMBzeSch/UqyAXdaBcJzRSTKCi2UHyWT/5aPczqf4eacyLgWpa/
> 3r+qqzljZ2F8MUbnyP71CyTufx+UQzoBAlB4kM09UcF9RC95XTSQrMBMB/SqR2Om
> +ebdE/d1e5ubExNQTbQPrb2OGCIiQhRGQo8MFcuFtgl2DabJFvW4QvsuJKinhQLR
> zcfupbRUPDegesKRU+es
> =phid
> -----END PGP SIGNATURE-----
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160504/d24b2f26/attachment.sig>