[Mesa-dev] [PATCH] i965: Only enable ARB_query_buffer_object for newer kernels on Haswell.

[Jordan Justen]

On 2016-05-05 10:11:24, Kenneth Graunke wrote:
> On Thursday, May 5, 2016 8:17:03 AM PDT Jordan Justen wrote:
> > On 2016-05-05 03:15:51, Kenneth Graunke wrote:
> > >  
> > > +   /* Haswell requires command parser version 6 in order to write to the
> > > +    * MI_MATH GPR registers, and version 7 in order to use
> > > +    * MI_LOAD_REGISTER_REG (which all users of MI_MATH use).
> > > +    */
> > > +   intelScreen->has_mi_math = intelScreen->devinfo->gen >= 8 ||
> > > +                              (intelScreen->devinfo->is_haswell &&
> > > +                               intelScreen->cmd_parser_version >= 7);
> > 
> > Do you think has_mi_math should imply LRR? Command parser version 6
> > should allow MI_MATH to be used. I guess the Vulkan driver uses
> > MI_MATH without LRR.
> > 
> > -Jordan
> 
> I'll admit, it's a little weird...originally this just checked for
> version 6.  But then I discovered that we needed MI_LOAD_REGISTER_REG
> too...both your query buffer code and my new ARB_transform_feedback2
> implementation use both commands.
> 
> I suppose we could rename it to has_mi_math_and_load_reg_reg?

has_mi_math_and_lrr?