[Mesa-dev] [PATCH] glsl: correctly handle inout parameters post function inlining

Lars Hamre chemecse at gmail.com
Fri May 6 14:49:18 UTC 2016


Sounds good to me, go ahead and push the new version!

On Fri, May 6, 2016 at 10:44 AM, Juan A. Suarez Romero
<jasuarez at igalia.com> wrote:
> On Fri, 2016-05-06 at 10:39 -0400, Lars Hamre wrote:
>> Hi Juan,
>>
>> Sorry I missed that.
>>
>> It looks like your patch doesn't fix the out parameter indexing for:
>> vs-inout-index-inout-mat2-col
>> vs-inout-index-inout-vec4-array
>>
>> I was able to extend your patch to get these tests passing by:
>>   - if the ir_array->array was a dereferenced_array, copy propagate
>> it's index
>>   - if the ir->ir_type == ir_type_swizzle, if it's val was a
>> dereferenced_array,
>>     copying propagate it's index
>
> That's great! Precisely, I have here a version that fixes those two
> test by doing exactly that :D
>
>
> I can push a new version with that change, or if you prefer doing it
> yourself, just let me know
>
>
>         J.A.
>


More information about the mesa-dev mailing list