[Mesa-dev] [PATCH] r300g: fix big endian support

[Michel Dänzer]

On 01.05.2016 23:11, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> The problem was that A8R8G8B8 was not supported, which is required
> for DRI2 window framebuffers on BE.
> 
> This patch:
> - adds support for ARGB 32bpp array formats for LE & BE using byteswapping
> - sets endian swap for packed formats as expected
> 
> ARGB is the only byteswapped array format. It's supported by programming it
> just like BGRA but also setting the swap control to get the reversed
> component order. Tested on R580 and little endian CPU.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71789
> 
> Cc: 11.1 11.2 <mesa-stable at lists.freedesktop.org>

While your argument in
https://bugs.freedesktop.org/show_bug.cgi?id=71789#c30 makes sense, the
commit log of this patch is rather misleading then. I suggest changing
the shortlog to something like

 radeonsi: Add support for PIPE_FORMAT_x8R8G8B8_*

and in the remaining log don't talk about "fixing" big endian support
but just mention that this allows r300g to at least run at all again on
big endian hosts, and reference the bug report.

With those changes,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer