[Mesa-dev] [PATCH] gallivm: use InternalLinkage instead of PrivateLinkage for texture functions

Jose Fonseca jfonseca at vmware.com
Mon May 9 13:23:38 UTC 2016


On 07/05/16 17:29, sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
>
> At least with MCJIT the disassembler will crash otherwise when trying to
> disassemble such functions.
> ---
>   src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
> index 31cf74f..3a8327d 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
> @@ -3320,7 +3320,7 @@ lp_build_sample_soa_func(struct gallivm_state *gallivm,
>         }
>
>         LLVMSetFunctionCallConv(function, LLVMFastCallConv);
> -      LLVMSetLinkage(function, LLVMPrivateLinkage);
> +      LLVMSetLinkage(function, LLVMInternalLinkage);
>
>         lp_build_sample_gen_func(gallivm,
>                                  static_texture_state,
>

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>


More information about the mesa-dev mailing list