[Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

Ian Romanick idr at freedesktop.org
Mon May 9 18:01:18 UTC 2016

On 05/03/2016 10:17 PM, Eric Anholt wrote:
> Brian Paul <brianp at vmware.com> writes:
>> On 05/02/2016 06:15 PM, Ilia Mirkin wrote:
>>> I know I've been sticking commas at the end of enums left and right
>>> for the past several years, and haven't heard any complaints. The nice
>>> thing about the trailing comma is that you avoid having to change
>>> unrelated lines when adding entries. This leads to cleaner per-line
>>> histories, which can be useful to see when something was added.
>> Yeah, I'd like to use trailing commas too, but I'd rather not see 
>> warnings.  I'm not sure why/when this started.
> I think we should just refuse to build with -Wpedantic, instead.

I believe Jose recently added -Wpedantic to catch some things that GCC
normally allows that MSVC does not.  Something about mixing C99 with
C++?  I don't recall the details.

I'm not a big fan of -Wpedantic either.

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160509/ddfdb016/attachment.sig>

More information about the mesa-dev mailing list