[Mesa-dev] [PATCH 3/3] genxml: avoid using GNU make extensions

[Chad Versace]

On Mon 02 May 2016, Jonathan Gray wrote:
> On Sun, May 01, 2016 at 10:32:18PM -0700, Jason Ekstrand wrote:
> > On May 1, 2016 1:56 AM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:
> > >
> > > On 1 May 2016 at 09:49, Jonathan Gray <jsg at jsg.id.au> wrote:
> > > > On Fri, Apr 22, 2016 at 05:57:40PM +0100, Emil Velikov wrote:

> > > Jason, Chad do you have any preference on the topic ? Should one tweak
> > > the generic rule to work everywhere or just expand it.

I prefer an unrepetitive approach, where a single rule expands to
generate all the files.

> > genX.pack.h sounds good to me
> 
> It seems it is possible to keep the existing names:

The filenames generated by the below hunk don't match the exsiting
names.

> diff --git a/src/intel/genxml/Makefile.am b/src/intel/genxml/Makefile.am
> index f493d48..ea68fb9 100644
> --- a/src/intel/genxml/Makefile.am
> +++ b/src/intel/genxml/Makefile.am
> @@ -28,7 +28,9 @@ BUILT_SOURCES =                                         \
>  
>  PYTHON3_GEN = $(AM_V_GEN)$(PYTHON3) $(PYTHON_FLAGS)
>  
> -%_pack.h : %.xml gen_pack_header.py
> +SUFFIXES = _pack.h .xml
> +
> +.xml_pack.h : gen_pack_header.py
>  	$(PYTHON3_GEN) $(srcdir)/gen_pack_header.py $< > $@
>  
>  CLEANFILES = $(BUILT_SOURCES)