[Mesa-dev] [PATCH 3/3] i965: Delete bogus assertion in emit_gs_input_load().

[Ilia Mirkin]

Can you have a point size for non-points? If not, there's only one
vertex, so I guess it has to be the first one, no?

On Mon, May 9, 2016 at 6:36 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> This looks like leftover cruft from an earlier attempt at writing
> point size hacks.  Each vertex has its own copy of gl_PointSize,
> so accessing any vertex other than 0 would cause this to fail.
>
> The tests seem to work fine without it.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index 33e4097..6a99b76 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -1770,7 +1770,6 @@ fs_visitor::emit_gs_input_load(const fs_reg &dst,
>        /* This input was pushed into registers. */
>        if (is_point_size) {
>           /* gl_PointSize comes in .w */
> -         assert(imm_offset == 0);
>           bld.MOV(dst, fs_reg(ATTR, imm_offset + 3, dst.type));
>        } else {
>           for (unsigned i = 0; i < num_components; i++) {
> --
> 2.8.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev