[Mesa-dev] [v4 07/11] i965/blorp: Do not resolve lossless compressed blit sources

[Pohjolainen, Topi]

On Mon, May 09, 2016 at 08:54:47PM +0300, Pohjolainen, Topi wrote:
> On Mon, May 09, 2016 at 10:39:44AM -0700, Ben Widawsky wrote:
> > On Thu, Apr 21, 2016 at 02:59:02PM +0300, Topi Pohjolainen wrote:
> > > Blorp blits use sampling engine which is capable of resolving
> > > on the fly.
> > 
> > We determined blitter does need the resolve? With that info added to the commit
> > message:
> 
> I didn't find anything in the spec telling way or the other. I suppose we can
> try this later on. I'll augment the commit.

Added:

   Buffers are still resolved for blitter engine. Current understanding
   is that blitter doesn't understand lossless compression.

> 
> > Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
> > 
> > > 
> > > Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> > > ---
> > >  src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
> > > index f33f4e1..74fe3c0 100644
> > > --- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
> > > +++ b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
> > > @@ -73,7 +73,7 @@ brw_blorp_blit_miptrees(struct brw_context *brw,
> > >      * to destination color buffers, and the standard render path is
> > >      * fast-color-aware.
> > >      */
> > > -   intel_miptree_resolve_color(brw, src_mt, 0);
> > > +   intel_miptree_resolve_color(brw, src_mt, INTEL_MIPTREE_IGNORE_CCS_E);
> > >     intel_miptree_slice_resolve_depth(brw, src_mt, src_level, src_layer);
> > >     intel_miptree_slice_resolve_depth(brw, dst_mt, dst_level, dst_layer);
> > >  
> > > -- 
> > > 2.5.5
> > > 
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev