[Mesa-dev] [PATCH v3 07/11] gallium: Add a pipe cap for arb_cull_distance

Marek Olšák maraeo at gmail.com
Tue May 10 08:26:37 UTC 2016


Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Sun, May 8, 2016 at 10:44 PM, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
> This lets us safely enable or disable the extension as needed
>
> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
> Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
> ---
>  src/gallium/docs/source/screen.rst               | 2 ++
>  src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
>  src/gallium/drivers/i915/i915_screen.c           | 1 +
>  src/gallium/drivers/ilo/ilo_screen.c             | 1 +
>  src/gallium/drivers/llvmpipe/lp_screen.c         | 1 +
>  src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 1 +
>  src/gallium/drivers/nouveau/nv50/nv50_screen.c   | 1 +
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c   | 1 +
>  src/gallium/drivers/r300/r300_screen.c           | 1 +
>  src/gallium/drivers/r600/r600_pipe.c             | 1 +
>  src/gallium/drivers/radeonsi/si_pipe.c           | 1 +
>  src/gallium/drivers/softpipe/sp_screen.c         | 1 +
>  src/gallium/drivers/svga/svga_screen.c           | 1 +
>  src/gallium/drivers/vc4/vc4_screen.c             | 1 +
>  src/gallium/include/pipe/p_defines.h             | 1 +
>  15 files changed, 16 insertions(+)
>
> diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst
> index 9451075..315a6a1 100644
> --- a/src/gallium/docs/source/screen.rst
> +++ b/src/gallium/docs/source/screen.rst
> @@ -336,6 +336,8 @@ The integer capabilities:
>    PIPE_CONTEXT_ROBUST_BUFFER_ACCESS. See the ARB_robust_buffer_access_behavior
>    extension for information on the required behavior for out of bounds accesses
>    and accesses to unbound resources.
> +* ``PIPE_CAP_CULL_DISTANCE``: Whether the driver supports the arb_cull_distance
> +  extension and thus implements proper support for culling planes.
>
>
>  .. _pipe_capf:
> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
> index fee44fa..916151c 100644
> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
> @@ -257,6 +257,7 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>         case PIPE_CAP_SURFACE_REINTERPRET_BLOCKS:
>         case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>         case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +       case PIPE_CAP_CULL_DISTANCE:
>                 return 0;
>
>         case PIPE_CAP_MAX_VIEWPORTS:
> diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c
> index 9b6a660..802b25f 100644
> --- a/src/gallium/drivers/i915/i915_screen.c
> +++ b/src/gallium/drivers/i915/i915_screen.c
> @@ -271,6 +271,7 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>
>     case PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS:
> diff --git a/src/gallium/drivers/ilo/ilo_screen.c b/src/gallium/drivers/ilo/ilo_screen.c
> index 2fc1873..ddeebc9 100644
> --- a/src/gallium/drivers/ilo/ilo_screen.c
> +++ b/src/gallium/drivers/ilo/ilo_screen.c
> @@ -500,6 +500,7 @@ ilo_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>
>     case PIPE_CAP_VENDOR_ID:
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
> index 4f61de8..c6c18ee 100644
> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
> @@ -321,6 +321,7 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>     }
>     /* should only get here on unhandled cases */
> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> index 400e9f5..87c3449 100644
> --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> +++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> @@ -194,6 +194,7 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>
>     case PIPE_CAP_VENDOR_ID:
> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> index ef114e5..0912150 100644
> --- a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> +++ b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> @@ -247,6 +247,7 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>
>     case PIPE_CAP_VENDOR_ID:
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> index bfbfead..da9eddc 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> @@ -261,6 +261,7 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>
>     case PIPE_CAP_VENDOR_ID:
> diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c
> index eae53e1..47dc275 100644
> --- a/src/gallium/drivers/r300/r300_screen.c
> +++ b/src/gallium/drivers/r300/r300_screen.c
> @@ -216,6 +216,7 @@ static int r300_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>          case PIPE_CAP_QUERY_MEMORY_INFO:
>          case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>         case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +        case PIPE_CAP_CULL_DISTANCE:
>              return 0;
>
>          /* SWTCL-only features. */
> diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
> index 52f0986..fd8881e 100644
> --- a/src/gallium/drivers/r600/r600_pipe.c
> +++ b/src/gallium/drivers/r600/r600_pipe.c
> @@ -366,6 +366,7 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>         case PIPE_CAP_STRING_MARKER:
>         case PIPE_CAP_QUERY_BUFFER_OBJECT:
>         case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +       case PIPE_CAP_CULL_DISTANCE:
>                 return 0;
>
>         case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
> index 61d5578..c34ad21 100644
> --- a/src/gallium/drivers/radeonsi/si_pipe.c
> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
> @@ -386,6 +386,7 @@ static int si_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>         case PIPE_CAP_GENERATE_MIPMAP:
>         case PIPE_CAP_STRING_MARKER:
>         case PIPE_CAP_QUERY_BUFFER_OBJECT:
> +       case PIPE_CAP_CULL_DISTANCE:
>                 return 0;
>
>         case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
> index 031602b..103e665 100644
> --- a/src/gallium/drivers/softpipe/sp_screen.c
> +++ b/src/gallium/drivers/softpipe/sp_screen.c
> @@ -272,6 +272,7 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_PCI_DEVICE:
>     case PIPE_CAP_PCI_FUNCTION:
>     case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>     case PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT:
>        return 4;
> diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c
> index d1bf6a3..fb03b56 100644
> --- a/src/gallium/drivers/svga/svga_screen.c
> +++ b/src/gallium/drivers/svga/svga_screen.c
> @@ -406,6 +406,7 @@ svga_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY:
>     case PIPE_CAP_QUERY_BUFFER_OBJECT:
>     case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
> +   case PIPE_CAP_CULL_DISTANCE:
>        return 0;
>     }
>
> diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c
> index 4dc84d4..86c2c3b 100644
> --- a/src/gallium/drivers/vc4/vc4_screen.c
> +++ b/src/gallium/drivers/vc4/vc4_screen.c
> @@ -209,6 +209,7 @@ vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>          case PIPE_CAP_PCI_FUNCTION:
>          case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
>          case PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR:
> +        case PIPE_CAP_CULL_DISTANCE:
>                  return 0;
>
>                  /* Stream output. */
> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> index bd02a79..262c3d1 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -726,6 +726,7 @@ enum pipe_cap
>     PIPE_CAP_PCI_FUNCTION,
>     PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT,
>     PIPE_CAP_ROBUST_BUFFER_ACCESS_BEHAVIOR,
> +   PIPE_CAP_CULL_DISTANCE,
>  };
>
>  #define PIPE_QUIRK_TEXTURE_BORDER_COLOR_SWIZZLE_NV50 (1 << 0)
> --
> 2.8.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list