[Mesa-dev] [v6 05/11] i965: Deferred allocation of mcs for lossless compressed

Pohjolainen, Topi topi.pohjolainen at intel.com
Tue May 10 17:03:13 UTC 2016


On Mon, May 09, 2016 at 10:30:25AM -0700, Ben Widawsky wrote:
> On Mon, May 09, 2016 at 10:29:28AM -0700, Ben Widawsky wrote:
> > On Fri, May 06, 2016 at 11:38:25AM +0300, Topi Pohjolainen wrote:
> > > Until now mcs was associated to single sampled buffers only for
> > > fast clear purposes and it was therefore the responsibility of the
> > > clear logic to allocate the aux buffer when needed. Now that normal
> > > 3D render or blorp blit may render with mcs enabled also, they need
> > > to prepare the mcs just as well.
> > > 
> > > v2: Do not enable for scanout buffers
> > > v3 (Ben):
> > >    - Fix typo in commit message.
> > >    - Check for gen < 9 and return early in brw_predraw_set_aux_buffers()
> > >    - Check for gen < 9 and return early in intel_miptree_prepare_mcs()
> > > 
> > > Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> > > Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
> > 
> > v5 is also Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
> 
> oops, v6 :P

This is afterall not good enough. It works when lossless compression is
enabled but adds unnecessary mcs allocation for normal 3d-render. I'll post
an update.


More information about the mesa-dev mailing list