[Mesa-dev] [PATCH] mesa/vbo: fix check for zero aliases with 2/10/10/10

[Ian Romanick]

It seems like at least some of these recent fixes should be candidates
for stable.

On 05/09/2016 08:37 PM, Kenneth Graunke wrote:
> On Tuesday, May 10, 2016 11:07:23 AM PDT Dave Airlie wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> This fixes:
>> GL33-
> CTS.gtf33.GL3Tests.vertex_type_2_10_10_10_rev.vertex_type_2_10_10_10_rev_attrib
>>
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>> ---
>>  src/mesa/vbo/vbo_attrib_tmp.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/vbo/vbo_attrib_tmp.h b/src/mesa/vbo/vbo_attrib_tmp.h
>> index e73b8fb..ed0b2de 100644
>> --- a/src/mesa/vbo/vbo_attrib_tmp.h
>> +++ b/src/mesa/vbo/vbo_attrib_tmp.h
>> @@ -226,7 +226,7 @@ static inline float conv_i2_to_norm_float(const struct 
> gl_context *ctx, int i2)
>>     } while(0)
>>  
>>  #define ATTR_UI_INDEX(ctx, val, type, normalized, index, arg) do {	\
>> -      if ((index) == 0) {					\
>> +      if ((index) == 0 && _mesa_attr_zero_aliases_vertex(ctx)) {	\
>>  	 ATTR_UI(ctx, val, (type), normalized, 0, (arg));		\
>>        } else if ((index) < MAX_VERTEX_GENERIC_ATTRIBS) {		\
>>  	 ATTR_UI(ctx, val, (type), normalized, VBO_ATTRIB_GENERIC0 + (index), 
> (arg)); \
>>
> 
> It does look like we do this in every other case, so...
> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160510/e273b5e5/attachment-0001.sig>