[Mesa-dev] [PATCH 0/6] Update generated GLX server code

Eric Anholt eric at anholt.net
Tue May 10 19:04:11 UTC 2016


Adam Jackson <ajax at redhat.com> writes:

> Another attempt at syncing the GLX generator scripts with xserver.
>
> Jon mentioned a couple of issues in the last series, namely that these two
> patches were still necessary:
>
> https://lists.x.org/archives/xorg-devel/2014-April/041597.html
> https://lists.x.org/archives/xorg-devel/2014-April/041919.html
>
> The former doesn't work at all: 'api' isn't a global, nor is it a parameter
> to emit_function_call(). So that's not included here, and anyone updating
> the xserver side will just need to be careful about the ARB_multitexture
> bits. It's also fairly ugly! Turns out there really isn't enough
> information attached to the entrypoint itself to be able to walk backward
> to the GL version or extension name directly. I've been fiddling with
> getting it working and not having a lot of fun.
>
> The latter is addressed in a different way, I've just dropped the "skip
> that which is marked for skipping" patch from the series. This means we
> will generate protocol code for NV_*_program again, which is harmless
> enough. But it does mean xserver will need to revert the commit that
> removes the open-coded size logic for GetProgramString.

I've looked through the python and the generated diff to the server.
The server's diff is still unreasonably huge, but this series' change to
the diff seems sensible to me.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160510/e17c21c7/attachment.sig>


More information about the mesa-dev mailing list