[Mesa-dev] [PATCH 08/15] i965/vec4: use attribute slots to calculate URB read length

Kenneth Graunke kenneth at whitecape.org
Tue May 10 20:19:47 UTC 2016


On Tuesday, May 10, 2016 6:24:39 PM PDT Juan A. Suarez Romero wrote:
> On Mon, 2016-05-09 at 23:37 -0700, Kenneth Graunke wrote:
> > void *log_data,
> > >     const unsigned *assembly = NULL;
> > >  
> > >     unsigned nr_attributes = _mesa_bitcount_64(prog_data-
> > >inputs_read);
> > > +   unsigned nr_attribute_slots = 0;
> > 
> > Can't you just do:
> > 
> >     nir_shader *nir = vp->program.Base.nir;
> >     unsigned nr_attribute_slots =
> >        _mesa_bitcount_64(nir->info.inputs_read) +
> >        _mesa_bitcount_64(nir->info.double_inputs_read);
> > 
> > It seems like that should work without the need to iterate variables.
> 
> 
> Right. I'll use that instead. Thank you!
> 
> 	J.A.
> 

Cool!  Have a:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160510/ef7cf561/attachment.sig>


More information about the mesa-dev mailing list