[Mesa-dev] [PATCH 3/3] i965/fs: Recognize and emit ld_lz, sample_lz, sample_c_lz.

Kenneth Graunke kenneth at whitecape.org
Tue May 10 23:57:05 UTC 2016


On Wednesday, May 4, 2016 5:41:37 PM PDT Kenneth Graunke wrote:
> On Wednesday, May 4, 2016 3:54:14 PM PDT Matt Turner wrote:
> > Ken suggested instead of a big and complicated optimization pass, to
> > just recognize the operations here. It's certainly less code and a lot
> > prettier, but it seems to actually perform worse for currently unknown
> > reasons.
> 
> One potential pitfall is that is_zero() currently returns false for
> -0.0f.  The fp64 series that's supposedly landing fixes this.
> 

That's fixed now.  With get_nir_src_imm simplified, this series is:

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I'm not sure why the other one does better, but this is better than
nothing, and it's really simple.  We may as well land it...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160510/cc08e0dc/attachment-0001.sig>


More information about the mesa-dev mailing list