[Mesa-dev] [PATCH] i965: Drop BRW_NEW_BLORP from stipple and line parameter packets.

Kenneth Graunke kenneth at whitecape.org
Wed May 11 07:07:26 UTC 2016


BLORP never touches these, and they're all non-pipelined.  Some
are fairly large packets as well.

I haven't tried to benchmark this; the effect is likely to be small.
However, we may as well stop the pointless papercuts; maybe they'll
add up someday.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_misc_state.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c
index 71a7fdd..436a619 100644
--- a/src/mesa/drivers/dri/i965/brw_misc_state.c
+++ b/src/mesa/drivers/dri/i965/brw_misc_state.c
@@ -749,8 +749,7 @@ const struct brw_tracked_state brw_polygon_stipple = {
    .dirty = {
       .mesa = _NEW_POLYGON |
               _NEW_POLYGONSTIPPLE,
-      .brw = BRW_NEW_BLORP |
-             BRW_NEW_CONTEXT,
+      .brw = BRW_NEW_CONTEXT,
    },
    .emit = upload_polygon_stipple
 };
@@ -789,8 +788,7 @@ const struct brw_tracked_state brw_polygon_stipple_offset = {
    .dirty = {
       .mesa = _NEW_BUFFERS |
               _NEW_POLYGON,
-      .brw = BRW_NEW_BLORP |
-             BRW_NEW_CONTEXT,
+      .brw = BRW_NEW_CONTEXT,
    },
    .emit = upload_polygon_stipple_offset
 };
@@ -821,8 +819,7 @@ upload_aa_line_parameters(struct brw_context *brw)
 const struct brw_tracked_state brw_aa_line_parameters = {
    .dirty = {
       .mesa = _NEW_LINE,
-      .brw = BRW_NEW_BLORP |
-             BRW_NEW_CONTEXT,
+      .brw = BRW_NEW_CONTEXT,
    },
    .emit = upload_aa_line_parameters
 };
@@ -862,8 +859,7 @@ upload_line_stipple(struct brw_context *brw)
 const struct brw_tracked_state brw_line_stipple = {
    .dirty = {
       .mesa = _NEW_LINE,
-      .brw = BRW_NEW_BLORP |
-             BRW_NEW_CONTEXT,
+      .brw = BRW_NEW_CONTEXT,
    },
    .emit = upload_line_stipple
 };
-- 
2.8.2



More information about the mesa-dev mailing list