[Mesa-dev] [PATCH] gallium/radeon: Rename gart_page_size member to bo_alignment

Marek Olšák maraeo at gmail.com
Wed May 11 10:42:09 UTC 2016


On Wed, May 11, 2016 at 11:28 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 11.05.2016 18:08, Marek Olšák wrote:
>> On Wed, May 11, 2016 at 8:22 AM, Michel Dänzer <michel at daenzer.net> wrote:
>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>
>>> This should make its meaning clearer.
>>>
>>> The value it holds is the CPU page size, which can be different from
>>> the GART page size.
>>
>> How about s/gart_page_size/page_size/g?
>
> Too ambiguous for my taste. (Which of CPU/GPU/GART/... page size is that? :)
>
>
>> The BO alignment will change once we add an allocator for small
>> buffers, but the page size won't change.
>
> And it'll also still be the minimum alignment of BOs allocated from the
> kernel. How about kernel_alignment or something like that?

Sounds good.

Marek


More information about the mesa-dev mailing list