[Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

[Emil Velikov]

Hi all,

On 11 May 2016 at 19:53, Kyle Brenneman <kbrenneman at nvidia.com> wrote:
> In the GLX dispatch functions, it should be safe to ignore a failed call to
> AddDrawableMapping. If it can't update the drawable-to-vendor hashtable at
> that point, then libGLX will just query the server when it needs to figure
> out the vendor.
>
Fair enough. Any objections if we do this as a follow up change ?

> In dispatch_ChooseFBConfigSGIX, if AddFBConfigsMapping fails, should it use
> free or XFree to free the memory?
>
In theory it should be XFree(). In practise that one has been a
wrapper around free() for a long time so I've went with the latter.

Kyle, Adam,
Any suggestions about the remaining XXX hunks in
src/glx/g_glxglvnddispatchfuncs.c ?

Thanks for squashing these, Adam !

I've confirmed that thing haven't gone crazy through the squash, so
barring any objections feel free to push.

Note to self: Send a patch that nukes the final if
defined(GLX_EXTENSION_FOO) hunks once these land.

Thanks
Emil

P.S. I did not bother on the symbol visibility front, since GLVND's
libGL will export every symbol imaginable.