[Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

Chuck Atkins chuck.atkins at kitware.com
Thu May 12 19:41:24 UTC 2016


>
> +    if test "x$enable_glx" = xno; then
> +        AC_MSG_ERROR([cannot build libglvnd without GLX])
> +    fi
> +
> +    if test "x$enable_xlib_glx" = xyes; then
> +        AC_MSG_ERROR([cannot build libgvnd when Xlib-GLX is enabled])
> +    fi
>

This doesn't consider the gallium-xlib implementation.  GLX configure
options are specified differently now as of:

a92910a glx: Refactor the configure options for glx implementation choice
(v3)

Basically all implementations are controlled via a single
--enable-glx=implementation option.  If you move the logic to after the
enable_glx option is validated, the you are guaranteed it's value will be
one of no, dri, xlib, or gallium-xlib.  Your logic can then be:

case "x$enable_glx" in
xno)
  AC_MSG_ERROR([cannot build libglvnd without GLX])
  ;;
xxlib | xgallium-xlib )
  AC_MSG_ERROR([cannot build libgvnd when Xlib-GLX or Gallium-Xlib-GLX is
enabled])
  ;;
xdri)
  ;;
esac
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160512/8c997d88/attachment-0001.html>


More information about the mesa-dev mailing list