[Mesa-dev] [PATCH 0/5] Resubmit: uninitialized warning fix + unit tests

[Ian Romanick]

Patches 1, 2, and 4 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I'm sending some comments on the other two.

On 05/10/2016 12:13 AM, Alejandro Piñeiro wrote:
> This is a resubmit of the pending patches related with the uninitialized
> warning, after two weeks since last comment.
> 
> This resubmit series merges two series hoping to make easier the review:
> 
>   * Fix the false positive with function parameters, that got a first
>     review by Ian Romanick [1]
>   * Unit texts for the uninitialized warning [2]
> 
> 
> [1] https://lists.freedesktop.org/archives/mesa-dev/2016-April/113614.html
> [2] https://lists.freedesktop.org/archives/mesa-dev/2016-April/113808.html
> 
> 
> Alejandro Piñeiro (5):
>   glsl: add a empty set_is_lhs on ast_node
>   glsl: do not raise uninitialized warning with in/inout function
>     parameters
>   glsl: add just-log option for the standalone compiler.
>   glsl: add warning-test
>   glsl: add unit tests data vertex/expected outcome for unitialized
>     warning
> 
>  src/compiler/Makefile.glsl.am                      |  3 ++-
>  src/compiler/glsl/ast.h                            |  2 ++
>  src/compiler/glsl/ast_function.cpp                 | 18 +++++++++++++
>  src/compiler/glsl/ast_to_hir.cpp                   |  5 ++++
>  src/compiler/glsl/main.cpp                         | 20 +++++++++++---
>  src/compiler/glsl/tests/warnings-test              | 31 ++++++++++++++++++++++
>  .../glsl/tests/warnings/000-basic-test.vert        | 10 +++++++
>  .../tests/warnings/000-basic-test.vert.expected    |  1 +
>  .../warnings/001-use-undefined-then-define.vert    | 12 +++++++++
>  .../001-use-undefined-then-define.vert.expected    |  1 +
>  src/compiler/glsl/tests/warnings/002-loop.vert     | 23 ++++++++++++++++
>  .../glsl/tests/warnings/002-loop.vert.expected     |  3 +++
>  src/compiler/glsl/tests/warnings/003-less.vert     | 17 ++++++++++++
>  .../glsl/tests/warnings/003-less.vert.expected     |  1 +
>  src/compiler/glsl/tests/warnings/004-greater.vert  | 17 ++++++++++++
>  .../glsl/tests/warnings/004-greater.vert.expected  |  1 +
>  src/compiler/glsl/tests/warnings/005-lequal.vert   | 17 ++++++++++++
>  .../glsl/tests/warnings/005-lequal.vert.expected   |  1 +
>  src/compiler/glsl/tests/warnings/006-gequal.vert   | 17 ++++++++++++
>  .../glsl/tests/warnings/006-gequal.vert.expected   |  1 +
>  src/compiler/glsl/tests/warnings/007-test-mod.vert | 25 +++++++++++++++++
>  .../glsl/tests/warnings/007-test-mod.vert.expected |  3 +++
>  .../glsl/tests/warnings/008-mulassign.vert         | 12 +++++++++
>  .../tests/warnings/008-mulassign.vert.expected     |  1 +
>  .../glsl/tests/warnings/009-div-assign.vert        | 12 +++++++++
>  .../tests/warnings/009-div-assign.vert.expected    |  1 +
>  .../glsl/tests/warnings/010-add-assign.vert        | 12 +++++++++
>  .../tests/warnings/010-add-assign.vert.expected    |  1 +
>  .../glsl/tests/warnings/011-sub-assign.vert        | 12 +++++++++
>  .../tests/warnings/011-sub-assign.vert.expected    |  1 +
>  .../glsl/tests/warnings/012-modassign.vert         | 12 +++++++++
>  .../tests/warnings/012-modassign.vert.expected     |  1 +
>  src/compiler/glsl/tests/warnings/013-lsassign.vert | 12 +++++++++
>  .../glsl/tests/warnings/013-lsassign.vert.expected |  1 +
>  src/compiler/glsl/tests/warnings/014-rsassign.vert | 12 +++++++++
>  .../glsl/tests/warnings/014-rsassign.vert.expected |  1 +
>  .../glsl/tests/warnings/015-andassign.vert         | 12 +++++++++
>  .../tests/warnings/015-andassign.vert.expected     |  1 +
>  src/compiler/glsl/tests/warnings/016-orassign.vert | 12 +++++++++
>  .../glsl/tests/warnings/016-orassign.vert.expected |  1 +
>  .../glsl/tests/warnings/017-xorassign.vert         | 12 +++++++++
>  .../tests/warnings/017-xorassign.vert.expected     |  1 +
>  src/compiler/glsl/tests/warnings/018-bitand.vert   | 24 +++++++++++++++++
>  .../glsl/tests/warnings/018-bitand.vert.expected   |  3 +++
>  src/compiler/glsl/tests/warnings/019-array.vert    | 23 ++++++++++++++++
>  .../glsl/tests/warnings/019-array.vert.expected    |  5 ++++
>  .../glsl/tests/warnings/020-array-length.vert      | 12 +++++++++
>  .../tests/warnings/020-array-length.vert.expected  |  0
>  src/compiler/glsl/tests/warnings/021-lshift.vert   | 25 +++++++++++++++++
>  .../glsl/tests/warnings/021-lshift.vert.expected   |  3 +++
>  src/compiler/glsl/tests/warnings/022-rshift.vert   | 25 +++++++++++++++++
>  .../glsl/tests/warnings/022-rshift.vert.expected   |  3 +++
>  src/compiler/glsl/tests/warnings/023-switch.vert   | 28 +++++++++++++++++++
>  .../glsl/tests/warnings/023-switch.vert.expected   |  3 +++
>  .../glsl/tests/warnings/024-shaderout.vert         | 19 +++++++++++++
>  .../tests/warnings/024-shaderout.vert.expected     |  2 ++
>  .../025-out-inout-function-parameters.vert         | 16 +++++++++++
>  ...025-out-inout-function-parameters.vert.expected |  1 +
>  .../glsl/tests/warnings/026-conditional.vert       | 17 ++++++++++++
>  .../tests/warnings/026-conditional.vert.expected   |  6 +++++
>  .../glsl/tests/warnings/027-fieldselection.vert    | 23 ++++++++++++++++
>  .../warnings/027-fieldselection.vert.expected      |  1 +
>  62 files changed, 593 insertions(+), 5 deletions(-)
>  create mode 100755 src/compiler/glsl/tests/warnings-test
>  create mode 100644 src/compiler/glsl/tests/warnings/000-basic-test.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/000-basic-test.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/001-use-undefined-then-define.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/001-use-undefined-then-define.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/002-loop.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/002-loop.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/003-less.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/003-less.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/004-greater.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/004-greater.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/005-lequal.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/005-lequal.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/006-gequal.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/006-gequal.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/007-test-mod.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/007-test-mod.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/008-mulassign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/008-mulassign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/009-div-assign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/009-div-assign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/010-add-assign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/010-add-assign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/011-sub-assign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/011-sub-assign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/012-modassign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/012-modassign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/013-lsassign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/013-lsassign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/014-rsassign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/014-rsassign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/015-andassign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/015-andassign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/016-orassign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/016-orassign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/017-xorassign.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/017-xorassign.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/018-bitand.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/018-bitand.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/019-array.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/019-array.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/020-array-length.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/020-array-length.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/021-lshift.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/021-lshift.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/022-rshift.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/022-rshift.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/023-switch.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/023-switch.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/024-shaderout.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/024-shaderout.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/025-out-inout-function-parameters.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/025-out-inout-function-parameters.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/026-conditional.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/026-conditional.vert.expected
>  create mode 100644 src/compiler/glsl/tests/warnings/027-fieldselection.vert
>  create mode 100644 src/compiler/glsl/tests/warnings/027-fieldselection.vert.expected
>