[Mesa-dev] [PATCH] i965: Make exec_size 16 word/byte registers use exec_size halving again.

Kenneth Graunke kenneth at whitecape.org
Fri May 13 07:02:14 UTC 2016


In a5d7e144eaf43fee37e6ff9e2de194407087632b, Connor generalized the
exec_size halving code to handle more cases.  However, he accidentally
made exec_size 16 instructions with word/byte types skip the halving
code, producing invalid regions, and regressing a lot of Piglit tests
on some 965GM systems.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95370
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Cc: Connor Abbott <cwabbott0 at gmail.com>
Cc: Francisco Jerez <currojerez at riseup.net>
Cc: Matt Turner <mattst88 at gmail.com>
---
 src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
index 4f6f3a3..383450b 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
@@ -65,7 +65,8 @@ brw_reg_from_fs_reg(fs_inst *inst, fs_reg *reg, unsigned gen)
    case VGRF:
       if (reg->stride == 0) {
          brw_reg = brw_vec1_reg(brw_file_from_reg(reg), reg->nr, 0);
-      } else if (inst->exec_size * reg->stride * type_sz(reg->type) <= 32) {
+      } else if (inst->exec_size <= 8 &&
+                 inst->exec_size * reg->stride * type_sz(reg->type) <= 32) {
          brw_reg = brw_vecn_reg(inst->exec_size, brw_file_from_reg(reg),
                                 reg->nr, 0);
          brw_reg = stride(brw_reg, inst->exec_size * reg->stride,
-- 
2.8.2



More information about the mesa-dev mailing list