[Mesa-dev] [PATCH 0/8] i965: Stop using brw_meta for blits and clears

[Pohjolainen, Topi]

On Thu, May 12, 2016 at 04:30:42PM -0700, Jason Ekstrand wrote:
> Now that blorp is up-and-running on gen9, there's not much stopping us from
> using blorp basically everywhere on gen6+.  The only real problem is 16x
> MSAA.  This little series adds 16x MSAA support to blorp and starts using
> it for practically everything.

I checked the 16 x msaa case, and it makes sense to me. Good call to
introduce the the nir_mask_shift_or() helper. Series is:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

> 
> Jason Ekstrand (8):
>   i965: Move brw_get_rb_for_slice to brw_meta_util
>   i965: Move brw_is_color_fast_clear_compatible to brw_meta_util
>   i965; Move brw_meta_get_*_rect to brw_meta_util.c
>   i965: move brw_meta_set_fast_clear_color to brw_meta_util.c
>   i965/blorp: Add support for 16x MSAA
>   i965: Use blorp for all updownsample blits
>   i965: Use blorp for all stencil blits
>   i965: Use blorp for all clears
> 
>  src/mesa/drivers/dri/i965/Makefile.sources        |   3 -
>  src/mesa/drivers/dri/i965/brw_blorp_blit.cpp      |  81 +-
>  src/mesa/drivers/dri/i965/brw_clear.c             |   8 -
>  src/mesa/drivers/dri/i965/brw_context.c           |   1 -
>  src/mesa/drivers/dri/i965/brw_context.h           |  29 -
>  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c   | 919 ----------------------
>  src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 566 -------------
>  src/mesa/drivers/dri/i965/brw_meta_updownsample.c | 150 ----
>  src/mesa/drivers/dri/i965/brw_meta_util.c         | 350 ++++++++
>  src/mesa/drivers/dri/i965/brw_meta_util.h         |   5 +
>  src/mesa/drivers/dri/i965/intel_fbo.c             |   7 +-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c     |  34 +-
>  12 files changed, 442 insertions(+), 1711 deletions(-)
>  delete mode 100644 src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
>  delete mode 100644 src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
>  delete mode 100644 src/mesa/drivers/dri/i965/brw_meta_updownsample.c
> 
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev