[Mesa-dev] [PATCH v2 17/30] i965/fs: support double with shared variable loads

Francisco Jerez currojerez at riseup.net
Sat May 14 00:20:32 UTC 2016


Samuel Iglesias Gonsálvez <siglesias at igalia.com> writes:

> From: Iago Toral Quiroga <itoral at igalia.com>
>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

If you change the argument ordering of do_untyped_vector_read make sure
you remember to update this patch.  With that taken into account:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index 4af5979..73b9082 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -3041,14 +3041,8 @@ fs_visitor::nir_emit_cs_intrinsic(const fs_builder &bld,
>        }
>  
>        /* Read the vector */
> -      fs_reg read_result = emit_untyped_read(bld, surf_index, offset_reg,
> -                                             1 /* dims */,
> -                                             instr->num_components,
> -                                             BRW_PREDICATE_NONE);
> -      read_result.type = dest.type;
> -      for (int i = 0; i < instr->num_components; i++)
> -         bld.MOV(offset(dest, bld, i), offset(read_result, bld, i));
> -
> +      do_untyped_vector_read(bld, surf_index, offset_reg,
> +                             dest, instr->num_components);
>        break;
>     }
>  
> -- 
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160513/955873bf/attachment.sig>


More information about the mesa-dev mailing list