[Mesa-dev] [PATCH v2 18/30] i965/fs: support doubles with SSBO loads

Francisco Jerez currojerez at riseup.net
Sat May 14 00:24:50 UTC 2016


Samuel Iglesias Gonsálvez <siglesias at igalia.com> writes:

> From: Iago Toral Quiroga <itoral at igalia.com>
>

Same comment as for PATCH 17, and likewise:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index 73b9082..ae95448 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -3516,13 +3516,8 @@ fs_visitor::nir_emit_intrinsic(const fs_builder &bld, nir_intrinsic_instr *instr
>        }
>  
>        /* Read the vector */
> -      fs_reg read_result = emit_untyped_read(bld, surf_index, offset_reg,
> -                                             1 /* dims */,
> -                                             instr->num_components,
> -                                             BRW_PREDICATE_NONE);
> -      read_result.type = dest.type;
> -      for (int i = 0; i < instr->num_components; i++)
> -         bld.MOV(offset(dest, bld, i), offset(read_result, bld, i));
> +      do_untyped_vector_read(bld, surf_index, offset_reg,
> +                             dest, instr->num_components);
>  
>        break;
>     }
> -- 
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160513/3ce9e030/attachment.sig>


More information about the mesa-dev mailing list