[Mesa-dev] [PATCH 02/14] vl/dri3: implement dri3 screen create and destroy

[Emil Velikov]

On 12 May 2016 at 16:25, Leo Liu <leo.liu at amd.com> wrote:
> On 05/12/2016 11:08 AM, Emil Velikov wrote:
>>
>> On 12 May 2016 at 15:01, Leo Liu <leo.liu at amd.com> wrote:
>>>
>>>
>>> On 05/12/2016 09:47 AM, Emil Velikov wrote:
>>>>
>>>> Hi Leo,
>>>>
>>>> On 11 May 2016 at 22:14, Leo Liu <leo.liu at amd.com> wrote:
>>>>>
>>>>> On 05/11/2016 04:20 PM, Axel Davy wrote:
>>>>>>
>>>>>> On 11/05/2016 17:06, Leo Liu wrote:
>>>>>>>
>>>>>>> Screen created with device fd returned from X server,
>>>>>>> also will bail out to DRI2 with certain conditions.
>>>>>>>
>>>>>>> Signed-off-by: Leo Liu <leo.liu at amd.com>
>>>>>>> ---
>>>>>>>     configure.ac                              |  7 ++-
>>>>>>>     src/gallium/auxiliary/vl/vl_winsys_dri3.c | 88
>>>>>>> ++++++++++++++++++++++++++++++-
>>>>>>>     2 files changed, 93 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/configure.ac b/configure.ac
>>>>>>> index 023110e..8c3960a 100644
>>>>>>> --- a/configure.ac
>>>>>>> +++ b/configure.ac
>>>>>>> @@ -1779,7 +1779,12 @@ if test "x$enable_xvmc" = xyes -o \
>>>>>>>             "x$enable_vdpau" = xyes -o \
>>>>>>>             "x$enable_omx" = xyes -o \
>>>>>>>             "x$enable_va" = xyes; then
>>>>>>> -    PKG_CHECK_MODULES([VL], [x11-xcb xcb xcb-dri2 >=
>>>>>>> $XCBDRI2_REQUIRED])
>>>>>>> +    if test x"$enable_dri3" = xyes; then
>>>>>>> +        PKG_CHECK_MODULES([VL], [xcb-dri3 xcb-present xcb-sync
>>>>>>> xshmfence
>>>>>>>>
>>>>>>>> = $XSHMFENCE_REQUIRED
>>>>>>>
>>>>>>> +                                 x11-xcb xcb xcb-dri2 >=
>>>>>>> $XCBDRI2_REQUIRED])
>>>>
>>>> We don't need xcb-dri2 in the above do we ?
>>>
>>>
>>> Yes I think so. That's for all vl, includes building vl_winsys_dri.c.
>>>
>>>
>> Yes we need it, or yes we don't need it ? Afaict the vl_winsys_dri.c
>> case is handled in the else statement.
>
> We still need vl_winsys_dri.c even with "enable_dri3", because there's
> fallback case.
>
Indeed you are correct - had a PEBKAC moment.

Thanks for the patience
Emil