[Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

Kai Wasserbäch kai at dev.carbon-project.org
Mon May 16 11:41:25 UTC 2016

Hey Kenneth,
Kenneth Graunke wrote on 16.05.2016 08:58:
> On Monday, May 9, 2016 5:42:28 PM PDT Kai Wasserbäch wrote:
>> while hunting the cause of fdo#95285 down, I tested these patches from your
>> tombraider-2 branch. But when applied the game started crashing, see
>> <https://bugs.freedesktop.org/show_bug.cgi?id=95285#c4>. Now, it might be 
> that
>> the omitted "glsl: Make lower_const_arrays_to_uniforms work directly on
>> constants." was the cause for that and you left it out because of that. If 
> not,
>> please have a look at <https://bugs.freedesktop.org/show_bug.cgi?
> id=95285#c4>.
>> If there is some additional test I should run, let me know.
>> Cheers,
>> Kai
> With X errors?  That doesn't seem like it would be caused by these
> patches...

well, I can only say, that without those patches the game started and with them,
it froze the system on entering the main menu forcing me to reboot (just to make
sure: before capturing the log I went through a full reboot without changing
Mesa or anything else, which should mean there shouldn't have been any kind of
old library version loaded or something similar). The X error was the only thing
I was able to log with „%command% >/path/to/log 2>&1“. Might be, that I didn't
log everything since the system froze up?

Again, if you have any kind of test in mind, I should run, I'm happy to.

Anyway if you're confident this is not connected and was some kind of fluke,
we'll certainly find out, once these patches land on master. ;-) I just thought
I point this out to you.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 630 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160516/ecc00161/attachment.sig>

More information about the mesa-dev mailing list