[Mesa-dev] vc4 Android build broken

Rob Herring robh at kernel.org
Mon May 16 22:39:07 UTC 2016


Eric,

The commit d36b28402f542 ("vc4: Reuse QPU disasm's cond flags in
QIR.") breaks on Android builds (using clang) with this error:

external/mesa3d/src/gallium/drivers/vc4/vc4_qpu_disasm.c:349:33:
error: format string is not a string literal (potentially insecure)
[-Werror,-Wformat-security]
                fprintf(stderr, DESC(qpu_add_opcodes, op_add));
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/mesa3d/src/gallium/drivers/vc4/vc4_qpu_disasm.c:228:9: note:
expanded from macro 'DESC'
        ((index >= ARRAY_SIZE(array) || !(array)[index]) ?         \
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


looks like it should be "fprintf(stderr, "%s", DESC(...))" as the
version for qpu_mul_opcodes is fine.

Rob


More information about the mesa-dev mailing list