[Mesa-dev] [PATCH 3/3] i965: Delete redundant extension enables

[Kenneth Graunke]

On Monday, May 16, 2016 12:24:23 PM PDT Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> A nearly identical block already exists in the gen >= 6 block above.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mesa/drivers/dri/i965/intel_extensions.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/
drivers/dri/i965/intel_extensions.c
> index 362a7e5..a6a080f 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -358,15 +358,6 @@ intelInitExtensions(struct gl_context *ctx)
>           if (brw->intelScreen->cmd_parser_version >= 2)
>              brw->predicate.supported = true;
>        }
> -
> -      /* Only enable this in core profile because other parts of Mesa 
behave
> -       * slightly differently when the extension is enabled.
> -       */
> -      if (ctx->API == API_OPENGL_CORE) {
> -         ctx->Extensions.ARB_viewport_array = true;
> -         ctx->Extensions.AMD_vertex_shader_viewport_index = true;
> -         ctx->Extensions.ARB_shader_subroutine = true;
> -      }
>     }
>  
>     if (brw->intelScreen->has_mi_math_and_lrr) {
> 

Weird.  You're right though, we're setting them on Gen6+ and setting
them a second time on Gen7+.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

You and Tim Rowley are probably going to have merge conflicts on GL3.txt...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160516/de6c25f6/attachment.sig>