[Mesa-dev] [PATCH 11/11] dri: Add YVU formats

Haixia Shi hshi at chromium.org
Mon May 16 23:47:36 UTC 2016


Kristian

(1), (2): thanks, I will try the latest patches
(3): sorry, this is not specific to YUV sampling patches. I believe
this problem has always been there.

On Mon, May 16, 2016 at 4:33 PM, Kristensen, Kristian H
<kristian.h.kristensen at intel.com> wrote:
> On Mon, May 16, 2016 at 4:21 PM, Haixia Shi <hshi at chromium.org> wrote:
>> Kristian
>>
>> While testing these we found several NULL pointer access and deadlock
>> problems with the YUV patches. I have uploaded a few proposed fixes,
>> can you take a look?
>
> Hi Haixia,
>
>> (1) i965: fix NULL pointer access in intel_image_target_texture_2d
>> If image->planar_format is NULL we need to fall back to invoke
>> intel_set_texture_image_bo().
>> https://chromium-review.googlesource.com/#/c/344280/
>>
>> (2) i965: fix NULL pointer access in gen8_update_texture_surface.
>> This appears to be yet another uncaught NULL pointer access caused by
>> the recent YUV support patches.
>> https://chromium-review.googlesource.com/#/c/344906/
>
> It looks like you're still using the first patch series I sent out. I
> think I fixed these issues already in the patches I sent to the list.
> You can also find the patches here:
> https://cgit.freedesktop.org/~krh/mesa/log/?h=external-yuv-v5
>
>> (3) platform_android: prevent deadlock in droid_swap_buffers
>> To avoid blocking other EGL calls, release the display mutex before we
>> enqueue buffer to android frameworks and re-acquire the mutex upon
>> return.
>> https://chromium-review.googlesource.com/#/c/343933/
>
> Is this specific to the EGLImage yuv sampling patches?
>
> thanks,
> Kristian
>
>> On Mon, May 16, 2016 at 12:54 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Please s/dri/dri_interface/ in the summary.
>>>
>>> Thanks
>>> Emil
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list