[Mesa-dev] [PATCH 08/18] swr: [rasterizer common] gcc/clang cleanup

Rowley, Timothy O timothy.o.rowley at intel.com
Tue May 17 15:23:59 UTC 2016


It seems to me that we shouldn’t be redefining offsetof at all, but rather including the appropriate header (cstddef) to make the definition available.  I’m removing this change and including that in swr’s os.h.  New title will read something like “swr: [rasterizer common] include cstddef instead of redefining offsetof"

-Tim

> On May 17, 2016, at 6:11 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> 
> Summary should really be "swr: ensure offsetof is defined" or alike ?
> Why you have it only for linux (defined(FORCE_LINUX) ||
> defined(__linux__) || defined(__gnu_linux__)) though ?
> 
> -Emil



More information about the mesa-dev mailing list