[Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

[Erik Faye-Lund]

On Wed, May 18, 2016 at 1:01 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 18 May 2016 at 09:27, Erik Faye-Lund <kusmabite at gmail.com> wrote:
>> On Wed, May 18, 2016 at 10:12 AM, Daniel Stone <daniel at fooishbar.org> wrote:
>>> Hi,
>>>
>>> On 18 May 2016 at 00:00, Ian Romanick <idr at freedesktop.org> wrote:
>>>> On 05/17/2016 09:59 AM, Ben Widawsky wrote:
>>>>> I think you misstated this. It's not invalid to have any other value. It's
>>>>> invalid to not have one of the 3 values, which I suppose is technically possible
>>>>> if you say support ES2, but not ES or GL (for example)
>>>>>
>>>>>  "Returns a string describing which client rendering APIs are supported. The
>>>>>   string contains a space-separate list of API names. The list must include at
>>>>>   least one of OpenGL, OpenGL_ES, or OpenVG. These strings correspond
>>>>>   respectively to values EGL_OPENGL_API, EGL_OPENGL_ES_API, and EGL_OPENVG_API
>>>>>   of the eglBindAPI, api argument."
>>>>>
>>>>> I am concerned by this change since I genuinely have no clue how EGL clients
>>>>> might currently be depending on this, and as such could I request that you not
>>>>> change the existing behavior (spit out when ES2 or ES3). At the bottom I put an
>>>>> untested version of what i would have done.
>>>>
>>>> I think this might be right.  Outside of Mesa sources, I can't find any
>>>> mention of OpenGL_ES2 or OpenGL_ES3 strings anywhere on the Internet.
>>>> At least VLC
>>>> (http://www.videolan.org/developers/vlc/modules/video_output/egl.c) uses
>>>> OpenGL_ES for both OpenGL ES 1.x and 2.x.
>>>
>>> Yes, and they'd be foolish not to: the proprietary Mali, PVR and
>>> Vivante drivers don't expose these strings, just OpenGL_ES, OpenGL and
>>> OpenVG. No idea what the proprietary Tegra drivers do, but I'd be
>>> surprised if they were different.
>>
>> The proprietary NV driver on Tegra 2 reports "OpenGL_ES2 OpenGL_ES
>> OpenGL OpenVG" for me :/
>
> Thanks Erik, I wish you had better news.
>
> So perhaps we could keep the ES2/ES3 strings for now, until we check
> with newer tegra 3/4 drivers (perhaps they removed it) or a few other
> programs than VLC ?
>

I also checked with my Tegra 3 device, and it has the same issue.

But do note that this string seems completely garbage to me: Tegra 2/3
doesn't support full OpenGL, yet they return it in the client query.
So I have doubts anyone is using this string for anything useful in
the first place.