[Mesa-dev] [RFC 1/7] nir/glsl_to_nir: quell some uninit_member coverity errors

Matt Turner mattst88 at gmail.com
Thu May 19 20:35:45 UTC 2016


On Wed, May 18, 2016 at 8:54 AM, Rob Clark <robdclark at gmail.com> wrote:
> From: Rob Clark <robclark at freedesktop.org>
>
> ---
>  src/compiler/nir/glsl_to_nir.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/compiler/nir/glsl_to_nir.cpp b/src/compiler/nir/glsl_to_nir.cpp
> index b25f065..3b487ff 100644
> --- a/src/compiler/nir/glsl_to_nir.cpp
> +++ b/src/compiler/nir/glsl_to_nir.cpp
> @@ -213,6 +213,13 @@ nir_visitor::nir_visitor(nir_shader *shader)
>                                               _mesa_key_pointer_equal);
>     this->overload_table = _mesa_hash_table_create(NULL, _mesa_hash_pointer,
>                                                    _mesa_key_pointer_equal);
> +   /* initialize these to quell warnings: */

It's good practice for the constructor to initialize the whole object,
so I don't think the comment adds anything.

Acked-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list