[Mesa-dev] [PATCH 01/10] glsl/linker: Silence unused parameter warning

Alejandro Piñeiro apinheiro at igalia.com
Fri May 20 09:40:00 UTC 2016


Series lgtm. Just sent a nitpick for patch 05, feel free to ignore it.

Series is:
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>

On 20/05/16 09:25, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The parameter is required for the interface.
>
> glsl/link_uniforms.cpp:689:61: warning: unused parameter ‘record_type’ [-Wunused-parameter]
>                              bool row_major, const glsl_type *record_type,
>                                                              ^
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/compiler/glsl/link_uniforms.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp
> index 92f1095..ff2989f 100644
> --- a/src/compiler/glsl/link_uniforms.cpp
> +++ b/src/compiler/glsl/link_uniforms.cpp
> @@ -686,7 +686,7 @@ private:
>     }
>  
>     virtual void visit_field(const glsl_type *type, const char *name,
> -                            bool row_major, const glsl_type *record_type,
> +                            bool row_major, const glsl_type * /* record_type */,
>                              const unsigned packing,
>                              bool /* last_field */)
>     {



More information about the mesa-dev mailing list