[Mesa-dev] [PATCH 1/3] mesa: Call TransformFeedback driver hooks before setting flags.

[Jordan Justen]

Series Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On 2016-05-09 15:18:21, Kenneth Graunke wrote:
> This way, the driver's EndTransformFeedback() hook can tell whether the
> transform feedback operation was paused.  It's also convenient to have
> Paused remain false until the driver's PauseTransformFeedback hook
> finishes.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/main/transformfeedback.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c
> index c92f0cc..9c06bc8 100644
> --- a/src/mesa/main/transformfeedback.c
> +++ b/src/mesa/main/transformfeedback.c
> @@ -505,12 +505,12 @@ _mesa_EndTransformFeedback(void)
>     FLUSH_VERTICES(ctx, 0);
>     ctx->NewDriverState |= ctx->DriverFlags.NewTransformFeedback;
>  
> +   assert(ctx->Driver.EndTransformFeedback);
> +   ctx->Driver.EndTransformFeedback(ctx, obj);
> +
>     ctx->TransformFeedback.CurrentObject->Active = GL_FALSE;
>     ctx->TransformFeedback.CurrentObject->Paused = GL_FALSE;
>     ctx->TransformFeedback.CurrentObject->EndedAnytime = GL_TRUE;
> -
> -   assert(ctx->Driver.EndTransformFeedback);
> -   ctx->Driver.EndTransformFeedback(ctx, obj);
>  }
>  
>  
> @@ -1173,10 +1173,10 @@ _mesa_PauseTransformFeedback(void)
>     FLUSH_VERTICES(ctx, 0);
>     ctx->NewDriverState |= ctx->DriverFlags.NewTransformFeedback;
>  
> -   obj->Paused = GL_TRUE;
> -
>     assert(ctx->Driver.PauseTransformFeedback);
>     ctx->Driver.PauseTransformFeedback(ctx, obj);
> +
> +   obj->Paused = GL_TRUE;
>  }
>  
>  
> -- 
> 2.8.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev