[Mesa-dev] [PATCH 2/7] i965: Unset alpha blend for R10G10B10_SNORM_A2_UNORM

[Eduardo Lima Mitev]

On 05/21/2016 03:12 AM, Jason Ekstrand wrote:
> From: Nanley Chery <nanley.g.chery at intel.com>
> 
> This format does not support alpha blending, according to the SNB PRM.
> 

In general, it helps (at least review) to add a quote or reference to
the related documentation. Certainly it doesn't hurt.

In this case: SNB PRM "Subsystem and Cores – Shared
Functions", section "2.11.2.1.2 Surface Format", page 90.

> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_surface_formats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> index 750f37a..d9a0ad7 100644
> --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c
> +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> @@ -125,7 +125,7 @@ const struct brw_surface_format_info surface_formats[] = {
>     SF( Y,  Y,  x,  x,  Y,  Y,  Y,  x, 60,    x,   R10G10B10A2_UNORM)
>     SF( Y,  Y,  x,  x,  x,  x,  x,  x, 60,    x,   R10G10B10A2_UNORM_SRGB)
>     SF( Y,  x,  x,  x,  Y,  x,  Y,  x,  x,    x,   R10G10B10A2_UINT)
> -   SF( Y,  Y,  x,  x,  x,  Y,  Y,  x,  x,    x,   R10G10B10_SNORM_A2_UNORM)
> +   SF( Y,  Y,  x,  x,  x,  x,  Y,  x,  x,    x,   R10G10B10_SNORM_A2_UNORM)
>     SF( Y,  Y,  x,  x,  Y,  Y,  Y,  x, 60,   90,   R8G8B8A8_UNORM)
>     SF( Y,  Y,  x,  x,  Y,  Y,  x,  x, 60,    x,   R8G8B8A8_UNORM_SRGB)
>     SF( Y,  Y,  x,  x,  Y, 60,  Y,  x,  x,   90,   R8G8B8A8_SNORM)
>