[Mesa-dev] [PATCH] anv/nir_apply_pipeline_layout: Pass the nir_src from the nir_tex_src

Jason Ekstrand jason at jlekstrand.net
Sat May 21 15:33:34 UTC 2016


Thanks. This was my bad. :-( I've been meaning to fox it.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
On May 21, 2016 12:31 AM, "Eduardo Lima Mitev" <elima at igalia.com> wrote:

> nir_instr_rewrite_src() expects a nir_src and it is currently being fed a
> nir_tex_src. This will crash something.
> ---
>  src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> index ddb099e..6481269 100644
> --- a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> +++ b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> @@ -163,7 +163,7 @@ lower_tex_deref(nir_tex_instr *tex, nir_deref_var
> *deref,
>            * first-class texture source.
>            */
>           tex->src[tex->num_srcs].src_type = src_type;
> -         nir_instr_rewrite_src(&tex->instr, &tex->src[tex->num_srcs],
> +         nir_instr_rewrite_src(&tex->instr, &tex->src[tex->num_srcs].src,
>                                 nir_src_for_ssa(index));
>           tex->num_srcs++;
>        } else {
> --
> 2.7.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160521/0bfc2e49/attachment.html>


More information about the mesa-dev mailing list