[Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

Vedran Miletic vedran at miletic.net
Sun May 22 20:29:51 UTC 2016


On 05/22/2016 10:13 PM, Giuseppe Bilotta wrote:
> On Sun, May 22, 2016 at 1:08 PM, Serge Martin <edb+mesa at sigluy.net> wrote:
>>
>> Mesa or MESA spelling shouldn't be an issue. And that would be coherent with
>> CL_PLATFORM_VENDOR that is returning "Mesa"
>
> Excellent. I'll unify the version string suffix to the title-cased version.
>

Very nice.

>>> Second question: shall I squash the introduction of the SHA1 in Clover
>>> with the introduction of the LLVM version everywhere, or should I keep
>>> those as separate patches?
>>
>> I have no opinion on that.
>
> I think I'll rework the thing as two separate patches (one to define
> the version string suffix in a single place, the other to add LLVM
> version to it).
>

Looking forward to reviewing these.

Regards,
Vedran

-- 
Vedran Miletić
vedran.miletic.net


More information about the mesa-dev mailing list