[Mesa-dev] [PATCH v2] doxygen: Add missing modules to Windows runner

[Emil Velikov]

On 20 May 2016 at 23:58, Rhys Kidd <rhyskidd at gmail.com> wrote:
> On 11 May 2016 at 07:51, Rhys Kidd <rhyskidd at gmail.com> wrote:
>>
>> On 10 May 2016 at 16:04, Elie TOURNIER <tournier.elie at gmail.com> wrote:
>>>
>>> ---
>>>  doxygen/doxy.bat | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/doxygen/doxy.bat b/doxygen/doxy.bat
>>> index e566ca3..408964e 100644
>>> --- a/doxygen/doxy.bat
>>> +++ b/doxygen/doxy.bat
>>> @@ -6,6 +6,9 @@ doxygen swrast_setup.doxy
>>>  doxygen tnl.doxy
>>>  doxygen core.doxy
>>>  doxygen glapi.doxy
>>> +doxygen glsl.doxy
>>> +doxygen nir.doxy
>>> +doxygen i965.doxy
>>>
>>>  echo Building again, to resolve tags
>>>  doxygen tnl_dd.doxy
>>> @@ -14,4 +17,8 @@ doxygen math.doxy
>>>  doxygen swrast.doxy
>>>  doxygen swrast_setup.doxy
>>>  doxygen tnl.doxy
>>> +doxygen core.doxy
>>>  doxygen glapi.doxy
>>> +doxygen glsl.doxy
>>> +doxygen nir.doxy
>>> +doxygen i965.doxy
>>> --
>>> 1.9.1
>>>
>>
>> Hello Elie,
>>
>> I think you meant to sign off your patch (passing the '-s' or '--signoff'
>> parameter to git format-patch). Shouldn't be a need to send a v3 for this
>> patch as you did do so on your v1. Whomever pushes the patch can add that
>> for you I'd expect.
>>
>> Whilst I don't have a Windows development environment to test this on it
>> looks sensible so gets my:
>> Acked-by: Rhys Kidd <rhyskidd at gmail.com>
>>
>> Thanks for the patch!
>
>
> Looks like this patch was never committed.
>
> Given neither myself nor Elie have Mesa commit rights, can we kindly request
> another (Emil?) to commit pre the upcoming freeze?
>
> I think my Acked-by is the strongest review this simple patch is likely to
> get.
>
Patch should be in master now. I've missed the original email and
noticed thanks to Rhys' reminder.

Feel free To/Cc me for future doxygen work and/or ping if things don't
get any attention.

Thanks
Emil



> Rhys