[Mesa-dev] [PATCH 1/2] Unify OpenGL and OpenCL version string suffix

[Emil Velikov]

On 23 May 2016 at 22:11, Giuseppe Bilotta <giuseppe.bilotta at gmail.com> wrote:
> Hello Emil,
>
> On Mon, May 23, 2016 at 11:20 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> It seems like this won't work if one builds --enable-clover --disable-dri.
>
> Argh, I hadn't considered this possibility.
>
>> The following should keep mesa and gallium code separate, can we try that one ?
>>  - move the git_sha1.h rule 'higher up' (src/Makefile.am perhaps ?)
>
> That makes perfect sense.
>
>> Please try and do the same for scons/android.
>
> I'll try. I've never used scons before thought so I might need some
> guidance along the way. (Doubly so considering that trying to run
>
> % scons
>
> on my work dir results in a backtrace about tuple not being callable
> on line 143 of the top-level SConstruct — python2 vs python3 issue
> maybe? This is on Debian unstable.)
>
Having python2 and 3 here. With the python being symlink to python3.
Haven't had any problems like that. If you cannot get it running,
please cc Jose (when sending the autoconf patch), he could be
interested in updating scons.

>>  - I'm split if we should have a single file or multiple or mesa and
>> gallium 'flavours' in respective folders.
>>  - introduce a st/clover header (please add it in the sources lists in
>> Makefile.sources) which is included in the respective places.
>>  - wire up the LLVM version/string in src/mesa (using HAVE_LLVM &
>> MESA_LLVM_VERSION_PATCH)
>>  - ^^ for st/clover.
>>  - print the LLVM version for r300 (based on r600_common_screen_init)
>>
>> How does this sound ?
>
> Well, that sort-of defeats the whole point of unifying the version
> string declaration, but it does make sense if we want to be selective
> about inclusion of the LLVM version string (to the drivers that
> actually use it).
>
I guess that's the part I did not get - why should mesa say "LLVM xxx"
if said driver does not use it ? Isn't that wrong and/or misleading
?For clover, llvmpipe, i915g and the gallium radeons - sure. But none
of the classic drivers, nouveau, freedreno... is using it so there's
no need adding it there ?

Regards,
Emil