[Mesa-dev] [PATCH] i965/gen7: Fix gl_HelperInvocation

Jordan Justen jordan.l.justen at intel.com
Tue May 24 03:44:42 UTC 2016


It appears that UV immediates aren't working on Ivy Bridge. In this
case, a signed version will work, and this fixes the piglit
tests/spec/glsl-4.50/execution/helper-invocation.shader_test test.

Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
Cc: Matt Turner <mattst88 at gmail.com>
---
 src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index eb81a3f..77e6820 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
@@ -302,7 +302,7 @@ emit_system_values_block(nir_block *block, fs_visitor *v)
                      stride(byte_offset(retype(brw_vec1_grf(1, 0),
                                                BRW_REGISTER_TYPE_UB), 28),
                             1, 8, 0),
-                     brw_imm_uv(0x76543210));
+                     brw_imm_v(0x76543210));
 
             /* A set bit in the pixel mask means the channel is enabled, but
              * that is the opposite of gl_HelperInvocation so we need to invert
-- 
2.8.1



More information about the mesa-dev mailing list