[Mesa-dev] [PATCH] i965: fix double-precision vertex inputs measurement

Kenneth Graunke kenneth at whitecape.org
Tue May 24 07:27:06 UTC 2016

On Friday, May 20, 2016 5:05:03 PM PDT Juan A. Suarez Romero wrote:
> For double-precision vertex inputs we need to measure them in dvec4
> terms, and for single-precision vertex inputs we need to measure them in
> vec4 terms.
> For the later case, we use type_size_vec4() function. For the former
> case, we had a wrong implementation based on type_size_vec4().
> This commit introduces a proper type_size_dvec4() function, that we use
> to measure vertex inputs.
> Measuring double-precision vertex inputs as dvec4 is required because
> ARB_vertex_attrib_64bit states that these uses the same number of
> locations than the single-precision version. That is, two consecutives
> dvec4 would be located in location "x" and location "x+1", not "x+2".
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp           |  2 +-
>  src/mesa/drivers/dri/i965/brw_shader.h         |  1 +
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 66 ++++++++++++++++++++------
>  3 files changed, 53 insertions(+), 16 deletions(-)

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160524/fcf3a1fa/attachment.sig>

More information about the mesa-dev mailing list