[Mesa-dev] [PATCH 11/14] mesa_glinterop: rename MESA_GLINTEROP_INVALID_{VALUE, VERSION}

Emil Velikov emil.l.velikov at gmail.com
Tue May 24 14:32:53 UTC 2016


From: Emil Velikov <emil.velikov at collabora.com>

Be more explicit what it actually does.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
If we're up for the idea of having INVALID_VALUE we can keep it. As-is
it there are no users for it (from mesa side).
---
 include/GL/mesa_glinterop.h           | 2 +-
 src/gallium/state_trackers/dri/dri2.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/GL/mesa_glinterop.h b/include/GL/mesa_glinterop.h
index a187a12..ff3235e 100644
--- a/include/GL/mesa_glinterop.h
+++ b/include/GL/mesa_glinterop.h
@@ -71,7 +71,7 @@ enum {
    MESA_GLINTEROP_OUT_OF_RESOURCES,
    MESA_GLINTEROP_OUT_OF_HOST_MEMORY,
    MESA_GLINTEROP_INVALID_OPERATION,
-   MESA_GLINTEROP_INVALID_VALUE,
+   MESA_GLINTEROP_INVALID_VERSION,
    MESA_GLINTEROP_INVALID_DISPLAY,
    MESA_GLINTEROP_INVALID_CONTEXT,
    MESA_GLINTEROP_INVALID_TARGET,
diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c
index bcca2f2..8b6af60 100644
--- a/src/gallium/state_trackers/dri/dri2.c
+++ b/src/gallium/state_trackers/dri/dri2.c
@@ -1469,7 +1469,7 @@ dri2_interop_query_device_info(__DRIcontext *_ctx,
    struct pipe_screen *screen = dri_context(_ctx)->st->pipe->screen;
 
    if (!out->version)
-      return MESA_GLINTEROP_INVALID_VALUE;
+      return MESA_GLINTEROP_INVALID_VERSION;
 
    out->pci_segment_group = screen->get_param(screen, PIPE_CAP_PCI_GROUP);
    out->pci_bus = screen->get_param(screen, PIPE_CAP_PCI_BUS);
@@ -1498,7 +1498,7 @@ dri2_interop_export_object(__DRIcontext *_ctx,
    boolean success;
 
    if (!in->version || !out->version)
-      return MESA_GLINTEROP_INVALID_VALUE;
+      return MESA_GLINTEROP_INVALID_VERSION;
 
    /* Validate the target. */
    switch (in->target) {
-- 
2.8.2



More information about the mesa-dev mailing list