[Mesa-dev] [PATCH 14/14] mesa_glinterop: make GL interop version field bidirectional

Marek Olšák maraeo at gmail.com
Tue May 24 16:52:39 UTC 2016


The series looks good overall.

Patches 2-8, 10-14:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Tue, May 24, 2016 at 4:32 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> This allows clear and easy communication between the two.
>
> Caller: Requesting information (struct vN)
> Callee: I know how to deal with older version (vN-1) only. Here is your
> data and the version I support.
> Caller: Older version ? Sure I'll cap all access to the fields provided
> by the older version (vN-1)
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> As said earlier, if people feel uneasy with this proposal (for which I
> don't blame them) I'm perfectly fine with dropping the patch.
>
> That said, the proposal does make sense from where I look at it.
> ---
>  include/GL/internal/dri_interface.h   |  2 +-
>  include/GL/mesa_glinterop.h           | 23 +++++++++++++++++++----
>  src/egl/drivers/dri2/egl_dri2.c       |  2 +-
>  src/egl/main/eglapi.c                 |  2 +-
>  src/egl/main/eglapi.h                 |  2 +-
>  src/gallium/state_trackers/dri/dri2.c |  9 ++++++++-
>  src/glx/dri2_priv.h                   |  2 +-
>  src/glx/dri3_priv.h                   |  2 +-
>  src/glx/dri_common_interop.c          |  4 ++--
>  src/glx/glxclient.h                   |  2 +-
>  src/glx/glxcmds.c                     |  2 +-
>  11 files changed, 37 insertions(+), 15 deletions(-)
>


More information about the mesa-dev mailing list