[Mesa-dev] [PATCH 01/11] i965/compute: Fix uniform init issue when SIMD8 is skipped

Kenneth Graunke kenneth at whitecape.org
Wed May 25 01:15:17 UTC 2016


On Tuesday, May 24, 2016 1:37:46 AM PDT Jordan Justen wrote:
> In d8347f12ead89c5a58f69ce9283a54ac8487159c, we added support for
> skipping SIMD8 generation when the program local size is too large for
> SIMD8 to be usable. This change was missed in that commit.
> 
> This bug would impact gen7 platforms when the compute shader local
> size is greater than 512, and gen8 platforms when the local size is
> greater than 448.
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index cc30838..f28583c 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -181,7 +181,7 @@ fs_visitor::nir_setup_outputs()
>  void
>  fs_visitor::nir_setup_uniforms()
>  {
> -   if (dispatch_width != 8)
> +   if (dispatch_width != min_dispatch_width)
>        return;
>  
>     uniforms = nir->num_uniforms / 4;
> 

This patch is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160524/406cb096/attachment.sig>


More information about the mesa-dev mailing list