[Mesa-dev] [PATCH 00/29] Make more use of bitmasks

[Mathias Fröhlich]

Hi Brian,

On Tuesday, May 24, 2016 11:29:56 Brian Paul wrote:
> On 05/24/2016 12:41 AM, Mathias.Froehlich at gmx.net wrote:
> > From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
> >
> > Hi all,
> >
> > following a series with performance improvements
> > for cpu/draw bound applications. This part makes
> > more use of the bitmask/ffs technique for iterating
> > a set of enabled items. The gains are not huge
> > but they are noticable for some of my favourite
> > workloads.
> >
> > Please review!
> 
> Overall looks good to me (though, see Roland's comment).  I like the 
> clean-ups.
> 
> Reviewed-by: Brian Paul <brianp at vmware.com>
> 
> However, in gallium we have a u_bit_scan() helper function for looping 
> over bitmasks.  I wonder if we should use something like that in Mesa 
> too.  What do you think?
> 
Thanks!

I was not aware of u_bit_scan but I like the way it is done.
Even though, can we leave this series as is and do something
like that on top?

Mathias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160525/6ae14516/attachment.html>